Fixing inconsistent usage of hono.auth#3695
Merged
sophokles73 merged 3 commits intoeclipse-hono:masterfrom Oct 1, 2025
Merged
Conversation
hono.auth had two functions, one where it contained a string to a) it was used to control the bean behavior in DelegatingAuthenticationServiceProducer the second function was being b) the config if that bean This led to inconsistency during the build process where the string hono.auth. e.g. hono.auth=delegating crashed the application during execution because the app excepts hono.auth to contain an object Thus, hono.auth controlling DelegatingAuthenticationServiceProducer was renamed to hono.authType
sophokles73
reviewed
Sep 30, 2025
Contributor
sophokles73
left a comment
There was a problem hiding this comment.
Thanks for the PR, just a small request ...
fixing typo
sophokles73
approved these changes
Oct 1, 2025
Contributor
sophokles73
left a comment
There was a problem hiding this comment.
LGTM
Thanks again for contributing 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hono.auth had two functions, one where it contained a string to a) it was used to control the bean behavior in DelegatingAuthenticationServiceProducer the second function was being
b) the config if that bean
This led to inconsistency during the build process where the string hono.auth. e.g. hono.auth=delegating crashed the application during execution because the app excepts hono.auth to contain an object
Thus, hono.auth controlling DelegatingAuthenticationServiceProducer was renamed to hono.authType