Moved Nexus URLs to properties.#57
Moved Nexus URLs to properties.#57bshannon merged 1 commit intoeclipse-ee4j:masterfrom Tomas-Kraus:master
Conversation
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
bshannon
left a comment
There was a problem hiding this comment.
Thanks for jumping on this, this is exactly what I wanted!
Merge it ASAP!
| --> | ||
| <release.arguments></release.arguments> | ||
| </properties> | ||
|
|
There was a problem hiding this comment.
just a nit-pick - why exactly has this code been moved around? It is creating a mess in history (aka git blame) as well as the PR harder to review (one needs to go through all lines to find changes). Probably nothing that important within the context of this project but anyway...
There was a problem hiding this comment.
I'm assuming this nit should not hold up moving forward on this.
There was a problem hiding this comment.
Think it's better human readable when you declare properties before using them. But this is not important.
There was a problem hiding this comment.
Think it's better human readable when you declare properties before using them.
Agreed!!!
Also moved properties above distributionManagement to declare sonatype properties before they are used.