17 feat abstractroutingdatasource implementation for multitenancy#39
Merged
Conversation
| /** Configurations for default tenant. */ | ||
| @Autowired(required = false) | ||
| private DatabaseProperties defaultDbProperties; | ||
| @Qualifier("tenants") |
Contributor
There was a problem hiding this comment.
Change name to tenantConfigMap
| // Initialize TenantContext with multitenancy flag | ||
| TenantContext.initialize(isMultitenancyEnabled); | ||
|
|
||
| if (!isMultitenancyEnabled) { |
Contributor
There was a problem hiding this comment.
Keep these removed changes for multitenancy check
| */ | ||
| @Bean("credentialsProvider") | ||
| public Map<String, CredentialsProvider> getCredentialsProvider() { | ||
| if (!isMultitenancyEnabled) { |
Contributor
There was a problem hiding this comment.
Keep this check for multitenancy. Read default tenant properties from tenantConfig.get(defaultTenatID)
| @Scheduled(fixedDelayString = "${" + PostgresDbConstants.POSTGRES_REFRESH_CHECK_INTERVAL | ||
| + ":86400000}") | ||
| public void postgresCredsRefreshJob() throws SQLException, InterruptedException { | ||
| Map<String, TenantDatabaseProperties> tenants = multiTenantDbProperties.getTenants(); |
Contributor
There was a problem hiding this comment.
Add check for multitenancy enabler similar to as in above methods.
| */ | ||
| @Bean | ||
| @ConfigurationProperties(prefix = "tenant") | ||
| public Map<String, TenantDatabaseProperties> tenants() { |
Contributor
There was a problem hiding this comment.
Can be renamed to tenantConfigMap
| @PostConstruct | ||
| public void init() { | ||
| healthCheckList = new ArrayList<>(); | ||
| if (!isMultitenancyEnabled) { |
Contributor
There was a problem hiding this comment.
Check needs to remain there
…eview comments
kaushalaroraharman
approved these changes
Dec 18, 2025
c20716a
into
eclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancy
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to our contributing docs for any questions on submitting a pull request.
Issues are required for both bug fixes and features.
Resolves #17
Describe behaviour before the change
Resolves the review comments
Describe behaviour after the change
Resolves the review comments
Pull request checklist
Does this introduce a breaking change?