Skip to content

Feature #17 SQL DAO Multitenancy Support - Assigned default value to …#36

Merged
kaushalaroraharman merged 1 commit intoeclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancyfrom
ihussainbadshah:17-feat-abstractroutingdatasource-implementation-for-multitenancy
Dec 4, 2025
Merged

Feature #17 SQL DAO Multitenancy Support - Assigned default value to …#36
kaushalaroraharman merged 1 commit intoeclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancyfrom
ihussainbadshah:17-feat-abstractroutingdatasource-implementation-for-multitenancy

Conversation

@ihussainbadshah
Copy link
Contributor

…multi.tenant.ids & Replaced hardcoded values with constants.

Please refer to our contributing docs for any questions on submitting a pull request.
Issues are required for both bug fixes and features.

Resolves #17


Describe behaviour before the change

  1. Assigned default value to multi.tenant.ids in @value annotation to prevent SpEL evaluation issue.
  2. Replaced hardcoded values in TenantDatabaseProperties with constants.

Describe behaviour after the change

Service won't require to include "multi.tenant.ids=" in their configmap in case of multitenancy.enabled=false.

Pull request checklist

  • I have read the CONTRIBUTING.md
  • My code follows the code style of this project
  • Tests for the changes have been added (for bug fixes / features)
  • All new and existing tests passed.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

…lt value to multi.tenant.ids & Replaced hardcoded values with constants.
@kaushalaroraharman kaushalaroraharman merged commit 47242de into eclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancy Dec 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants