GitHub Feature #17 Added DependsOn to prevent a race condition.#32
Conversation
2f9a6f8
into
eclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancy
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to our contributing docs for any questions on submitting a pull request.
Issues are required for both bug fixes and features.
Resolves #17
Describe behaviour before the change
A couple of class - PostgresDbHealthMonitor.java and PostgresDbHealthService.java were not previously depending upon a bean - PostgresDbConfig which is responsible for the initialization of tenantId -> targetDataSource map. This map's instance is injected into former classes and because of the dependency issue, a race condition may occur where those classes may use the map before it's completely initialized causing abnormal behavior.
Describe behaviour after the change
PostgresDbHealthMonitor.java and PostgresDbHealthService.java have been made dependent upon the config class to ensure proper initialization order.
Pull request checklist
Does this introduce a breaking change?