Skip to content

Fix NullPointerException in IgnitePostgresDbMetricsExporter at shutdowm#15

Merged
kaushalaroraharman merged 1 commit intomainfrom
bugfix/nullpointer-prometheus-export-server
Apr 29, 2025
Merged

Fix NullPointerException in IgnitePostgresDbMetricsExporter at shutdowm#15
kaushalaroraharman merged 1 commit intomainfrom
bugfix/nullpointer-prometheus-export-server

Conversation

@kaushalaroraharman
Copy link
Contributor

@kaushalaroraharman kaushalaroraharman commented Apr 29, 2025 •
edited
Loading

Resolves #ISSUE_NUMBER

Describe behaviour before the change

  • NullPointerException was occurring during shutdown since prometheusExportServer is initialized based on a configuration, can can be a case where it is not being used.

Describe behaviour after the change

  • Added a null check on prometheusExportServer before closing it.

Pull request checklist

  • I have read the CONTRIBUTING.md
  • My code follows the code style of this project
  • Tests for the changes have been added (for bug fixes / features)
  • All new and existing tests passed.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

@kaushalaroraharman kaushalaroraharman self-assigned this Apr 29, 2025
@kaushalaroraharman kaushalaroraharman added the bug Something isn't working label Apr 29, 2025
@kaushalaroraharman kaushalaroraharman added this to the 1.1.2 milestone Apr 29, 2025
@kaushalaroraharman kaushalaroraharman linked an issue Apr 29, 2025 that may be closed by this pull request
[BUG]: NullPointerException while using prometheus HTTPServer #14
Closed
1 task
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kaushalaroraharman kaushalaroraharman merged commit c1b91aa into main Apr 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kaushalaroraharman kaushalaroraharman

Labels

bug Something isn't working

Projects

None yet

Milestone

1.1.2

Development

Successfully merging this pull request may close these issues.

[BUG]: NullPointerException while using prometheus HTTPServer

1 participant

@kaushalaroraharman