Skip to content

Updating device-client source code#1

Merged
nayandeshpandeharman merged 3 commits intoeclipse-ecsp:mainfrom
nayandeshpandeharman:main
Mar 18, 2025
Merged

Updating device-client source code#1
nayandeshpandeharman merged 3 commits intoeclipse-ecsp:mainfrom
nayandeshpandeharman:main

Conversation

@nayandeshpandeharman
Copy link
Contributor

No description provided.

Copy link
Contributor

@premHarman premHarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this search YAML workflow file. The intention was to go to public org without any traces of customer keywords.

@nayandeshpandeharman
Copy link
Contributor Author

Please remove this search YAML workflow file. The intention was to go to public org without any traces of customer keywords.

Updated.

Copy link
Contributor

@premHarman premHarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nayan,

  1. Remove search.yml file from workflows.
  2. Replace "HARMAN-Automotive" with "eclipse-ecsp"
  3. Replace "opensourceharman" with "csp".

Please check these thoroughly in the entire repo.

}
},
"HCPAuth": {
"activate_url": "https://api-gateway3.poc.opensourceharman.com/v4/device/activate/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace the URL "api-gateway3.poc.opensourceharman.com" with "api-gateway.poc.csp.com"? I believe anyone who is using this will need to change this according to their deployment.

},
"HCPAuth": {
"activate_url": "https://api-gateway3.poc.opensourceharman.com/v4/device/activate/",
"auth_url": "https://auth-server.poc.opensourceharman.com/oauth2/token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace the URL "api-gateway3.poc.opensourceharman.com" with "api-gateway.poc.csp.com"? I believe anyone who is using this will need to change this according to their deployment.

Thanks for helping make GitHub Open Source Software safe for everyone.

GitHub takes the security of our software products and services seriously, including all the open source code repositories managed through our GitHub organizations, such as [HARMAN-Automotive](https://github.com/HARMAN-Automotive).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace "HARMAN-Automotive" with "eclipse-ecsp". Not only in this line, But everywhere throughout the repo.

}
},
"MQTT": {
"host": "hivemq.poc.opensourceharman.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "opensourceharman" with "csp".

@nayandeshpandeharman nayandeshpandeharman merged commit 7157abd into eclipse-ecsp:main Mar 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants