Skip to content

Fix deploy on openshift#2225

Merged
thjaeckle merged 8 commits intoeclipse-ditto:masterfrom
dguarascio:pid_path_openshift
Sep 29, 2025
Merged

Fix deploy on openshift#2225
thjaeckle merged 8 commits intoeclipse-ditto:masterfrom
dguarascio:pid_path_openshift

Conversation

@dguarascio
Copy link
Contributor

@dguarascio dguarascio commented Sep 16, 2025 •
edited by thjaeckle
Loading

This should address #2207, I manually tested the path for the pidfile with oc apply -f nginx-configmap-patched.yaml -n <my_namespace>, nginx pod correctly started:

+ curl -sL -w '%{http_code}\n' http://<my_namespace>:8080/health -o /dev/null
+ '[[' 200 '!=' 200 ]]
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf differs from the packaged version
/docker-entrypoint.sh: Sourcing /docker-entrypoint.d/15-local-resolvers.envsh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up

EDIT: I spotted another permission problem with swaggerui image, in the initScript a new temporary folder is created: mkdir -p ~/openapi, on openshift this result in: mkdir: can't create directory '//openapi': Permission denied, the reason seems that the random user used to spawn the container doesn't have a home folder, so this tries to create the folder in the root, resulting in a permission denied, in commit 71befe6 I changed the initScript to directly work into /init-config folder that is a volume mounted and writable, if you have better alternatives feel free to modify my fix

Resolves: #2207

@dguarascio dguarascio changed the title Fix nginx pidfile path for openshift Fix deploy on openshift Sep 16, 2025
@thjaeckle
Copy link
Member

thjaeckle commented Sep 16, 2025

Thanks @dguarascio for the contribution - looks good so far.

Could you please adhere to the CONTRIBUTING.md and create an Eclipse Account where you sign the Contributor Agreement?

There is one check from a Bot user by the Eclipse foundation which makes sure that only people with signed Eclipse ECA might contribute to the projects - for legal reasons.

Also, please bump the Helm chart version.

@dguarascio
Copy link
Contributor Author

dguarascio commented Sep 25, 2025

Sorry for the delay, I was trying to register on the eclipse website but a very funny thing blocks me to do it:
image
Obviously the top level domain contains a dot 😅

Do you know where I can report the issue?

@thjaeckle
Copy link
Member

thjaeckle commented Sep 25, 2025

Hm, the ticketing system at the Eclipse Foundation also requires to have an Eclipse account.

I would suggest to write to the webmaster:
https://wiki.eclipse.org/WebMaster

@dguarascio
sign commit
58d468f 
Signed-off-by: Daniele Guarascio <daniele.guarascio@gridspertise.com>
@thjaeckle thjaeckle added this to the 3.8.0 milestone Sep 29, 2025
@Guara92
Copy link

Guara92 commented Sep 29, 2025

Let me know if I need to bump the chart version too.
Any chance that this can be backported to 3.5?

@thjaeckle
Copy link
Member

thjaeckle commented Sep 29, 2025 •
edited
Loading

@dguarascio cool, the ECA check now passed, thanks for going through that process 👍

Could you just bump the version in the Chart.yaml to 3.8.0-M10 in order to satisfy the helm linting?

@dguarascio
Bump chart version
aa715c2 
Signed-off-by: Daniele Guarascio <daniele.guarascio@gridspertise.com>
@thjaeckle
Copy link
Member

thjaeckle commented Sep 29, 2025

Any chance that this can be backported to 3.5?

No - this is not worth the effort. You could create an own Helm chart, forking the release-3.5 branch if you need it.
Updating to 3.6 and 3.7 (and soon to 3.8) should however be quite easy to do ..
Only from 3.5 to 3.6 there were some changes in the Ditto UI configuration which need some migration steps: https://eclipse.dev/ditto/release_notes_360.html

thjaeckle
thjaeckle reviewed Sep 29, 2025
View reviewed changes
@dguarascio
Bump chart version
3e5f7e7 
Signed-off-by: Daniele Guarascio <daniele.guarascio@gridspertise.com>
@dguarascio
Double space
b126e10 
Signed-off-by: Daniele Guarascio <daniele.guarascio@gridspertise.com>
thjaeckle
thjaeckle approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have it green :)

Thanks a lot for the contribution @dguarascio

@thjaeckle thjaeckle merged commit ce24304 into eclipse-ditto:master Sep 29, 2025
9 checks passed
@dguarascio
Copy link
Contributor Author

dguarascio commented Sep 29, 2025

Thanks for the patience and support!

@dguarascio dguarascio deleted the pid_path_openshift branch September 29, 2025 15:15
@dguarascio dguarascio mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

+1 more reviewer

@Guara92 Guara92 Guara92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dguarascio dguarascio

Labels

Helm chart

Projects

Ditto Planning
Status: Done

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

Openshift deploy nginx issue

3 participants

@dguarascio @thjaeckle @Guara92