Skip to content

#2176: adding support for OAuth2 grant type "password" for HTTP-push connections#2195

Merged
thjaeckle merged 2 commits intoeclipse-ditto:masterfrom
beyonnex-io:feature/connection-http-support-password-grant-flow
Jul 21, 2025
Merged

#2176: adding support for OAuth2 grant type "password" for HTTP-push connections#2195
thjaeckle merged 2 commits intoeclipse-ditto:masterfrom
beyonnex-io:feature/connection-http-support-password-grant-flow

Conversation

@thjaeckle
Copy link
Member

Resolves: #2176

@thjaeckle thjaeckle added this to the 3.8.0 milestone Jun 26, 2025
@thjaeckle thjaeckle self-assigned this Jun 26, 2025
@thjaeckle thjaeckle moved this to Waiting for Approval in Ditto Planning Jun 26, 2025
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki could you please check + approve this PR?

Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.
Since the password field is sensitive would it make sense to use the FieldEncryptionConfig or the simpler approach with the ConnectionUri.createUriStringWithMaskedPassword()

@thjaeckle
Copy link
Member Author

FieldEncryptionConfig

Yes, indeed .. I forgot about FieldEncryptionConfig again :D
Thanks for the hint - will add it to the "known" pointers.

@thjaeckle thjaeckle force-pushed the feature/connection-http-support-password-grant-flow branch from 813ebe5 to 1e30cb3 Compare July 21, 2025 07:36
Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit c260f5b into eclipse-ditto:master Jul 21, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Waiting for Approval to Done in Ditto Planning Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add support for "password" OAuth grant-type for HTTP connections

2 participants