Optimize withAll for primitive bag factories#1376
Optimize withAll for primitive bag factories#1376donraab merged 1 commit intoeclipse-collections:masterfrom TheJavaGuy:1372-optimize-withAll-on-bags
Conversation
|
hi @TheJavaGuy - we usually squash all commits into a single one as per the guide here https://github.com/eclipse/eclipse-collections/blob/master/CONTRIBUTING.md |
donraab
left a comment
There was a problem hiding this comment.
Hi @TheJavaGuy, thank you for the contribution! I have a few changes requested inline. I appreciate all of the detail you have in the commits. It was helpful understanding the issues you encountered using toImmutable as I suggested in the issue. After you make the requested changes, you can squash the commits/rebase and I will review again and approve/merge assuming everything looks good.
...llections-code-generator/src/main/resources/impl/bag/immutable/immutablePrimitiveHashBag.stg
Show resolved
Hide resolved
unit-tests/src/test/java/org/eclipse/collections/impl/stream/PrimitiveStreamsTest.java
Show resolved
Hide resolved
|
Hi @TheJavaGuy, the changes look good. Please update the commit message to added closes with the issue number. Thanks! |
donraab
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution @TheJavaGuy !
Please review this PR commit by commit starting from the earliest one. I’ve structured commits to be small and self-contained changes.
Every commit has a detailed message that explains why it was done that way. Of course, if you have additional questions I’m more than happy to answer them.
Closes #1372