Conversation
ashbeitz
reviewed
Feb 14, 2024
ashbeitz
left a comment
There was a problem hiding this comment.
One suggestion. Please take a look.
devkelley
reviewed
Feb 14, 2024
devkelley
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
Motivation and Context
This is solving a separation of concerns problem in which a full scenario example should be separated from the core repository. This way, if people want to clone Chariott core, they do not also need all of the dependencies and the large example scenario. There is now the chariott-example-applications repository which is a more suitable place for it.
Description