Skip to content

Update to dotnet 8#274

Merged
juileetikekar merged 6 commits intomainfrom
jtikekar/updateDotnet8
Feb 28, 2025
Merged

Update to dotnet 8#274
juileetikekar merged 6 commits intomainfrom
jtikekar/updateDotnet8

Conversation

@juileetikekar
Copy link
Contributor

This PR includes changes w.r.t.:

  1. Dotnet upgrade
  2. Fixing security vulnerabilities

@juileetikekar juileetikekar merged commit 57f90cc into main Feb 28, 2025
5 of 6 checks passed
@Kaz040
Copy link
Contributor

Kaz040 commented Mar 3, 2025

Hi @juileetikekar ,

The update to dotnet 8 is making all plugins not to work because the path definition in the config file that load them is wrong. See the image below.

image

You need to refactor the paths to ....net8.0-windows.... for packageExplorer to be able to load the plugins.

In my oppinion, two config files are affected and their path are

src\AasxPackageExplorer\options-debug.json
src\AasxPackageExplorer\options-debug.MIHO.json

with the latter taking precedence.

@juileetikekar
Copy link
Contributor Author

Hi @Kaz040,

that is strange, when I downloaded the AASPE (https://github.com/eclipse-aaspe/package-explorer/actions/runs/13583846578) on my end, the plugins work fine:

image

I will have a look.

@Kaz040
Copy link
Contributor

Kaz040 commented Mar 3, 2025

Nice that there is a test release. Maybe the release action overwrite those paths....

I actually used my forked repo which I synced with upstream repo.

If everything is working with released package, there might not be a need to mess with main repo. You can take your time to look at it and decide if refactor is necessary.

@juileetikekar
Copy link
Contributor Author

Hi @Kaz040,

Although I could not reproduce the issue. I have refactored the files to remove the inconsistency. Could you please test the plugins on your end?

Thanks in advance.

@Kaz040
Copy link
Contributor

Kaz040 commented Mar 3, 2025

@juileetikekar, Thank you for your work and quick response. I will test the repo now.

I looked at the release also, it is working fine for plugins because the program now points to release path and not debug path.

Another thing that I noticed in the release is that, Project AasxPluginAssetInterfaceDesc.csproj is not part of the projects that is compiled in the release(see image below) so it functionality is missing in the release.

image

I think this issue can be resolved by adding AasxPluginAssetInterfaceDesc to BuildForRelease.ps1 file (from line 40 - 57).

Please could you add this project and rerun the Action that compile the release.

Thank you so much for work and prompt response.

@Kaz040
Copy link
Contributor

Kaz040 commented Mar 4, 2025

Hi @Kaz040,

Although I could not reproduce the issue. I have refactored the files to remove the inconsistency. Could you please test the plugins on your end?

Thanks in advance.

After testing the repo this morning. The plugins are loaded as expected. Thank you.

@juileetikekar
Copy link
Contributor Author

juileetikekar commented Mar 4, 2025

@juileetikekar, Thank you for your work and quick response. I will test the repo now.

I looked at the release also, it is working fine for plugins because the program now points to release path and not debug path.

Another thing that I noticed in the release is that, Project AasxPluginAssetInterfaceDesc.csproj is not part of the projects that is compiled in the release(see image below) so it functionality is missing in the release.

image

I think this issue can be resolved by adding AasxPluginAssetInterfaceDesc to BuildForRelease.ps1 file (from line 40 - 57).

Please could you add this project and rerun the Action that compile the release.

Thank you so much for work and prompt response.

The issue with AasxPluginAssetInterfaceDesc not being part of release, is still there, right?

Also, do you see this plugin as a part of Blazor explorer?

@Kaz040
Copy link
Contributor

Kaz040 commented Mar 4, 2025

@juileetikekar, Thank you for your work and quick response. I will test the repo now.
I looked at the release also, it is working fine for plugins because the program now points to release path and not debug path.
Another thing that I noticed in the release is that, Project AasxPluginAssetInterfaceDesc.csproj is not part of the projects that is compiled in the release(see image below) so it functionality is missing in the release.
image
I think this issue can be resolved by adding AasxPluginAssetInterfaceDesc to BuildForRelease.ps1 file (from line 40 - 57).
Please could you add this project and rerun the Action that compile the release.
Thank you so much for work and prompt response.

The issue with AasxPluginAssetInterfaceDesc not being part of release, is still there, right?

Also, do you see this plugin as a part of Blazor explorer?

Hi @juileetikekar , Yes the plugin is still missing. Unfortunately, the job was half way done. I looked into the Action that run the Check-release job(see image below).

image

The Build for release job ran successfully (see image below)
image.

But however, the Package job ran without copying the directory of AasxPluginAssetInterfaceDesc project into the package. Looking into the package job, I saw that it is using this script https://github.com/eclipse-aaspe/package-explorer/blob/main/src/PackageRelease.ps1.

To complete the task, I think AasxPluginAssetInterfaceDesc need to be added to the PackageRelease.ps1 (inside $smallPlugins -->from line 33 and $blazorPlugins --> from line 51 variables ). see image below.

image

@juileetikekar
Copy link
Contributor Author

Yes, I noticed that too. I will add the project to both the packageExplore (windows) as well as Blazor Explorer (web), if the plugin supports both.

@juileetikekar
Copy link
Contributor Author

done

@Kaz040
Copy link
Contributor

Kaz040 commented Mar 4, 2025

done

I just made a quick test on the release. It is working as expected. Thank you for the support!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants