Skip to content

Conversation

…13.3.0.eb, tomlplusplus-3.4.0-GCCcore-13.3.0.eb and patches: hictk-2.1.4_CMake_deps.patch
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Updated software spdlog-1.15.3-GCCcore-13.3.0.eb

Diff against spdlog-1.15.3-GCCcore-14.2.0.eb

easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.2.0.eb

diff --git a/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.2.0.eb b/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-13.3.0.eb
index 7b1f2627bc..d725b74ada 100644
--- a/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.2.0.eb
+++ b/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-13.3.0.eb
@@ -4,21 +4,22 @@ name = 'spdlog'
 version = '1.15.3'
 
 homepage = 'https://github.com/gabime/spdlog'
-description = "Very fast, header-only/compiled, C++ logging library."
+description = 'Very fast, header-only/compiled, C++ logging library.'
 
-toolchain = {'name': 'GCCcore', 'version': '14.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
-source_urls = ['https://github.com/gabime/%(name)s/archive/refs/tags/']
+source_urls = ['https://github.com/gabime/spdlog/archive/refs/tags/']
 sources = ['v%(version)s.tar.gz']
 checksums = ['15a04e69c222eb6c01094b5c7ff8a249b36bb22788d72519646fb85feb267e67']
 
 builddependencies = [
     ('binutils', '2.42'),
-    ('CMake', '3.31.3'),
+    ('CMake', '3.29.3'),
 ]
+
 sanity_check_paths = {
-    'files': ['include/%(name)s/%(name)s.h'],
-    'dirs': ['lib64/cmake', 'lib64/pkgconfig'],
+    'files': ['include/spdlog/spdlog.h', 'lib/libspdlog.a'],
+    'dirs': ['lib/cmake', 'lib/pkgconfig'],
 }
 
 moduleclass = 'lib'
Diff against spdlog-1.15.3-GCCcore-14.3.0.eb

easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb

diff --git a/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb b/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-13.3.0.eb
index bc174194d0..d725b74ada 100644
--- a/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-14.3.0.eb
+++ b/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-13.3.0.eb
@@ -4,21 +4,22 @@ name = 'spdlog'
 version = '1.15.3'
 
 homepage = 'https://github.com/gabime/spdlog'
-description = "Very fast, header-only/compiled, C++ logging library."
+description = 'Very fast, header-only/compiled, C++ logging library.'
 
-toolchain = {'name': 'GCCcore', 'version': '14.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
-source_urls = ['https://github.com/gabime/%(name)s/archive/refs/tags/']
+source_urls = ['https://github.com/gabime/spdlog/archive/refs/tags/']
 sources = ['v%(version)s.tar.gz']
 checksums = ['15a04e69c222eb6c01094b5c7ff8a249b36bb22788d72519646fb85feb267e67']
 
 builddependencies = [
-    ('binutils', '2.44'),
-    ('CMake', '4.0.3'),
+    ('binutils', '2.42'),
+    ('CMake', '3.29.3'),
 ]
+
 sanity_check_paths = {
-    'files': ['include/%(name)s/%(name)s.h'],
-    'dirs': ['lib64/cmake', 'lib64/pkgconfig'],
+    'files': ['include/spdlog/spdlog.h', 'lib/libspdlog.a'],
+    'dirs': ['lib/cmake', 'lib/pkgconfig'],
 }
 
 moduleclass = 'lib'
Diff against spdlog-1.12.0-GCCcore-13.3.0.eb

easybuild/easyconfigs/s/spdlog/spdlog-1.12.0-GCCcore-13.3.0.eb

diff --git a/easybuild/easyconfigs/s/spdlog/spdlog-1.12.0-GCCcore-13.3.0.eb b/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-13.3.0.eb
index eead269814..d725b74ada 100644
--- a/easybuild/easyconfigs/s/spdlog/spdlog-1.12.0-GCCcore-13.3.0.eb
+++ b/easybuild/easyconfigs/s/spdlog/spdlog-1.15.3-GCCcore-13.3.0.eb
@@ -1,26 +1,25 @@
 easyblock = 'CMakeMake'
 
 name = 'spdlog'
-version = '1.12.0'
+version = '1.15.3'
 
 homepage = 'https://github.com/gabime/spdlog'
-description = "Very fast, header-only/compiled, C++ logging library."
+description = 'Very fast, header-only/compiled, C++ logging library.'
 
 toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
-source_urls = ['https://github.com/gabime/%(name)s/archive/refs/tags/']
+source_urls = ['https://github.com/gabime/spdlog/archive/refs/tags/']
 sources = ['v%(version)s.tar.gz']
-checksums = ['4dccf2d10f410c1e2feaff89966bfc49a1abb29ef6f08246335b110e001e09a9']
+checksums = ['15a04e69c222eb6c01094b5c7ff8a249b36bb22788d72519646fb85feb267e67']
 
 builddependencies = [
     ('binutils', '2.42'),
     ('CMake', '3.29.3'),
 ]
 
-
 sanity_check_paths = {
-    'files': ['include/%(name)s/%(name)s.h'],
-    'dirs': ['lib64/cmake', 'lib64/pkgconfig'],
+    'files': ['include/spdlog/spdlog.h', 'lib/libspdlog.a'],
+    'dirs': ['lib/cmake', 'lib/pkgconfig'],
 }
 
 moduleclass = 'lib'

@Thyre Thyre added the 2024a issues & PRs related to 2024a common toolchains label Oct 7, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Oct 10, 2025
@boegel
Copy link
Member

boegel commented Oct 10, 2025

@PetrKralCZ Some easyconfigs missing to resolve all dependencies?

ERROR: Missing dependencies: fmt/11.2.0-foss-2024a, bshoshany-thread-pool/5.0.0 (no easyconfig file or existing module found)

edit: fixed with:

@boegel
Copy link
Member

boegel commented Oct 10, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24138 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24138 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8288

Test results coming soon (I hope)...

Details

- notification for comment with ID 3391652012 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4878d8d2ea03044298e5bad373f5f5b2 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 10, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24138 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24138 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8290

Test results coming soon (I hope)...

Details

- notification for comment with ID 3391764454 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Oct 10, 2025

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node4210.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/593a7004503487542591ea2f40a58ef7 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7defaf8f813450139d4fe21d0213f044 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 10, 2025

found 2 variants of 'spdlog' dependency in easyconfigs using '2024a' toolchain generation
* version: 1.12.0; versionsuffix:  as dep for {'REViewer-0.2.7-foss-2024a.eb'}
* version: 1.15.3; versionsuffix:  as dep for {'hictk-2.1.4-foss-2024a.eb'}

@PetrKralCZ Do we really need spdlog 1.15.3?

@PetrKralCZ
Copy link
Collaborator Author

found 2 variants of 'spdlog' dependency in easyconfigs using '2024a' toolchain generation
* version: 1.12.0; versionsuffix:  as dep for {'REViewer-0.2.7-foss-2024a.eb'}
* version: 1.15.3; versionsuffix:  as dep for {'hictk-2.1.4-foss-2024a.eb'}

@PetrKralCZ Do we really need spdlog 1.15.3?

@boegel Yes. Because of compatibility with fmt. But spdlog can be a build dependency. 92f858f

@PetrKralCZ
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24138 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24138 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8366

Test results coming soon (I hope)...

Details

- notification for comment with ID 3402613218 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/983f61b49e511078d3af7f878c74537a for a full test report.

@boegel
Copy link
Member

boegel commented Oct 14, 2025

found 2 variants of 'spdlog' dependency in easyconfigs using '2024a' toolchain generation
* version: 1.12.0; versionsuffix:  as dep for {'REViewer-0.2.7-foss-2024a.eb'}
* version: 1.15.3; versionsuffix:  as dep for {'hictk-2.1.4-foss-2024a.eb'}

@PetrKralCZ Do we really need spdlog 1.15.3?

@boegel Yes. Because of compatibility with fmt. But spdlog can be a build dependency. 92f858f

Excellent!

@PetrKralCZ Same is probably true for some other dependencies, like readerwriterqueue is header-only so should also be a build-only dependency? Likewise for tomlplusplus ?

@PetrKralCZ
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24138 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24138 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8490

Test results coming soon (I hope)...

Details

- notification for comment with ID 3421732413 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/66d7e5ede53b0ce393a6847efff67998 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 21, 2025

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3541.doduo.os - Linux RHEL 9.6, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/boegel/159c0fa479ffb3608ce28764d606218f for a full test report.

@boegel
Copy link
Member

boegel commented Oct 21, 2025

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node4206.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/19d4ccb4e8b5265290d2c70f46a261dd for a full test report.

@boegel
Copy link
Member

boegel commented Oct 21, 2025

Going in, thanks @PetrKralCZ!

@boegel boegel merged commit d045263 into easybuilders:develop Oct 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains new update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants