Skip to content

clean up easyconfigs so they don't explicitly enable keepsymlinks, since it's now enabled by default #22573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Mar 16, 2025
Merged

clean up easyconfigs so they don't explicitly enable keepsymlinks, since it's now enabled by default #22573

boegel merged 1 commit into from
Mar 16, 2025

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Mar 15, 2025 •
edited
Loading

List of affected easyconfigs:

  • a/ADF/ADF-2019.303-intelmpi.eb
  • a/AMS/AMS-2020.102-iimpi-2020b-intelmpi.eb
  • a/AMS/AMS-2022.102-iimpi-2021b-intelmpi.eb
  • a/AMS/AMS-2023.101-iimpi-2022a-intelmpi.eb
  • a/AMS/AMS-2023.104-iimpi-2022b-intelmpi.eb
  • b/BEDOPS/BEDOPS-2.4.41-foss-2021b.eb
  • b/BEDOPS/BEDOPS-2.4.41-foss-2023a.eb
  • b/BEDOPS/BEDOPS-2.4.41-foss-2023b.eb
  • c/CellRanger-ARC/CellRanger-ARC-1.0.1.eb
  • c/CellRanger-ARC/CellRanger-ARC-2.0.0.eb
  • c/CellRanger-ARC/CellRanger-ARC-2.0.1.eb
  • c/CellRanger-ARC/CellRanger-ARC-2.0.2.eb
  • c/CellRanger-ATAC/CellRanger-ATAC-1.2.0.eb
  • c/CellRanger-ATAC/CellRanger-ATAC-2.0.0.eb
  • c/CellRanger-ATAC/CellRanger-ATAC-2.1.0.eb
  • c/CellRanger/CellRanger-4.0.0.eb
  • c/CellRanger/CellRanger-5.0.0.eb
  • c/CellRanger/CellRanger-5.0.1.eb
  • c/CellRanger/CellRanger-6.0.0.eb
  • c/CellRanger/CellRanger-6.0.1.eb
  • c/CellRanger/CellRanger-6.0.2.eb
  • c/CellRanger/CellRanger-6.1.2.eb
  • c/CellRanger/CellRanger-7.0.0.eb
  • c/CellRanger/CellRanger-7.1.0.eb
  • c/CellRanger/CellRanger-7.2.0.eb
  • c/CellRanger/CellRanger-8.0.0.eb
  • c/CellRanger/CellRanger-8.0.1.eb
  • c/CellRanger/CellRanger-9.0.0.eb
  • n/netMHCII/netMHCII-2.3.eb
  • s/Spack/Spack-0.16.2.eb
  • s/Spack/Spack-0.17.0.eb
  • s/Spack/Spack-0.17.2.eb
  • s/Spack/Spack-0.21.2.eb
  • s/SqueezeMeta/SqueezeMeta-1.5.0-foss-2021b.eb
  • s/sonic/sonic-20180202-gfbf-2023a.eb

@lexming lexming added this to the 5.0.0 milestone Mar 15, 2025
@lexming lexming changed the title remove default keepsymlink = True option from easyconfigs remove default keepsymlink option from easyconfigs Mar 15, 2025
boegel
boegel approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 16, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="BEDOPS-2.4.41-foss-2023b.eb"
EB_BRANCH=5.0.x

@boegelbot
Copy link
Collaborator

boegelbot commented Mar 16, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=22573 EB_ARGS="BEDOPS-2.4.41-foss-2023b.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_22573 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5960

Test results coming soon (I hope)...

Details

- notification for comment with ID 2727286476 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Mar 16, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/e516362467a7d81a7f1ce3b4233489d8 for a full test report.

@boegel boegel changed the title remove default keepsymlink option from easyconfigs clean up easyconfigs so they don't explicitly enable keepsymlinks, since it's now set by default Mar 16, 2025
@boegel boegel changed the title clean up easyconfigs so they don't explicitly enable keepsymlinks, since it's now set by default clean up easyconfigs so they don't explicitly enable keepsymlinks, since it's now enabled by default Mar 16, 2025
@boegel boegel merged commit 933ca85 into easybuilders:5.0.x Mar 16, 2025
8 checks passed
@lexming lexming deleted the rm-keepsymlinks branch March 16, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change code cleanup EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegel @boegelbot