Skip to content

clean up ancient version support in custom easyblock for ROOT #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Micket merged 2 commits into from
Jul 15, 2025
Merged

clean up ancient version support in custom easyblock for ROOT #3841

Micket merged 2 commits into from
Jul 15, 2025

Conversation

@branfosj
Copy link
Member

@branfosj branfosj commented Jul 14, 2025 •
edited
Loading

(created using eb --new-pr)

This drops support for versions <= 6.10 - the last easyconfigs we had for that old versions were in 2016 toolchains.

@branfosj branfosj added this to the release after 5.1.1 milestone Jul 14, 2025
Micket
Micket approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket mentioned this pull request Jul 14, 2025
Merged
@Micket
Copy link
Contributor

Micket commented Jul 14, 2025

test report in easybuilders/easybuild-easyconfigs#23416

@branfosj
Copy link
Member Author

branfosj commented Jul 15, 2025

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS CFITSIO-3.49-GCCcore-11.2.0.eb
  • SUCCESS CFITSIO-4.2.0-GCCcore-11.3.0.eb
  • SUCCESS freeglut-3.4.0-GCCcore-12.2.0.eb
  • SUCCESS freeglut-3.4.0-GCCcore-12.3.0.eb
  • SUCCESS GL2PS-1.4.2-GCCcore-12.2.0.eb
  • SUCCESS GL2PS-1.4.2-GCCcore-12.3.0.eb
  • SUCCESS ROOT-6.26.10-foss-2022b.eb
  • SUCCESS ROOT-6.30.06-foss-2023a.eb
  • SUCCESS freeglut-3.2.1-GCCcore-11.2.0.eb
  • SUCCESS freeglut-3.2.2-GCCcore-11.3.0.eb
  • SUCCESS GL2PS-1.4.2-GCCcore-11.2.0.eb
  • SUCCESS GL2PS-1.4.2-GCCcore-11.3.0.eb
  • SUCCESS ROOT-6.24.06-foss-2021b.eb
  • SUCCESS ROOT-6.26.06-foss-2022a.eb

Build succeeded for 14 out of 14 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/e79120b564e5e879bec45c311588eda1 for a full test report.

@Micket Micket merged commit 195b648 into easybuilders:develop Jul 15, 2025
17 checks passed
@branfosj branfosj deleted the 20250714193603_new_pr_root branch July 15, 2025 21:21
@boegel boegel changed the title cleanup ancient version support in root.py cleanup ancient version support in custom easyblock for ROOT Jul 30, 2025
@boegel boegel changed the title cleanup ancient version support in custom easyblock for ROOT clean up ancient version support in custom easyblock for ROOT Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

change code cleanup

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @Micket