Skip to content

Conversation

@Flamefire
Copy link
Contributor

Set the same defaults for exts_list and components

E.g. jax uses absl-py in its components and sets default_easyblock = 'PythonPackage' which is a bit confusing.

Change the default from None (error when no custom easyblock exists) to PythonPackage

Set the same defaults for `exts_list` and `components`
@Flamefire
Copy link
Contributor Author

Test with easybuilders/easybuild-easyconfigs#22449 is successful

@boegel boegel added the change label Mar 13, 2025
@boegel boegel changed the base branch from develop to 5.0.x March 13, 2025 12:51
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Mar 13, 2025
@boegel boegel added this to the 5.0 milestone Mar 13, 2025
@boegel
Copy link
Member

boegel commented Mar 13, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS ml_dtypes-0.3.2-gfbf-2023a.eb
  • SUCCESS PyQt5-5.15.10-GCCcore-13.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3508.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/853c3447b31f48fd503eefa9c1c4cad3 for a full test report.

@boegel boegel merged commit 8e916db into easybuilders:5.0.x Mar 13, 2025
17 checks passed
@Flamefire Flamefire deleted the pythonbundle-def-eb branch March 13, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants