Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Apr 12, 2020

to deal with divering software version (like '2019R3') vs version used in subdir (like 'v195')

…with divering software version (like '2019R3') vs version used in subdir (like 'v195')
@smoors
Copy link
Contributor

smoors commented Apr 13, 2020

@boegel this is ok to me, but I wonder if you can't somehow extract the subdir_version from the sources directly?

@akesandgren
Copy link
Contributor

@smoors fluent is packedbinary so not much sources there...

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 1cec89d into easybuilders:develop May 4, 2020
@boegel boegel deleted the FLUENT_subdir_version branch May 4, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants