limit MPI ranks used for running WRF test cases to max. 4 + include contents of rsl.error.0000 output file in case test failed #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontents of rsl.error.0000 output file in case test failed
akesandgren
reviewed
Dec 14, 2019
| test_cmd = "ulimit -s unlimited && ./ideal.exe && ./wrf.exe >rsl.error.0000 2>&1" | ||
|
|
||
| # regex to check for successful test run | ||
| re_success = re.compile("SUCCESS COMPLETE WRF") |
Contributor
There was a problem hiding this comment.
Why move this outside of run_test ??
Member
Author
There was a problem hiding this comment.
Because there's no point in recompiling the same regex over and over again :)
Contributor
There was a problem hiding this comment.
Thought that would be it, but doesn't it have to be in self. then??
Still don't quite understand Python...
Contributor
There was a problem hiding this comment.
Ah, should have looked at the whole file...
run_test is inside test_step, that explains it.
Member
Author
There was a problem hiding this comment.
run_test is an inner method, sort of like a local variable in the test_step method (but it's a function, not a variable), so it has access to all local variables in test_step
Contributor
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into problems with running the WRF 4.0.1 test cases (using the easyconfigs in easybuilders/easybuild-easyconfigs#7085) when too many cores were available.
Some tests were crashing because too many MPI ranks were used, and the domain size was too small...
It took me a while to realize why the tests were failing, because they were just exiting with exit code
1, not producing any output, so I've also enhanced the test step to read thersl.error.0000output file (from MPI rank 0) and include the output in the error message that is produced when the test failed to run.