Skip to content

fix(coding-agent): list themes by content name#4830

Merged
badlogic merged 1 commit into
earendil-works:mainfrom
Perlence:fix/theme-picker-content-names
May 21, 2026
Merged

fix(coding-agent): list themes by content name#4830
badlogic merged 1 commit into
earendil-works:mainfrom
Perlence:fix/theme-picker-content-names

Conversation

@Perlence

@Perlence Perlence commented May 20, 2026

Copy link
Copy Markdown
Contributor

If the theme's content name differs from its file name, both names will appear in the settings:

$ ls ~/.pi/agent/themes/
light-ansi.json@
$ head -3 ~/.pi/agent/themes/light-ansi.json
{
        "$schema": "https://raw.githubusercontent.com/earendil-works/pi/main/packages/coding-agent/src/modes/interactive/theme/theme-schema.json",
        "name": "light-ansi-lol",

Theme

Select color theme

  dark
  light
  light-ansi
→ light-ansi-lol

  Enter to select · Esc to go back

I went with treating the content name as the primary one, because DefaultResourceLoader dedupes themes by the name rather than file path:

Theme

Select color theme

  dark
  light
→ light-ansi-lol

  Enter to select · Esc to go back

@badlogic badlogic merged commit a93c6a5 into earendil-works:main May 21, 2026
3 checks passed
@badlogic

badlogic commented May 21, 2026

Copy link
Copy Markdown
Collaborator

cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Perlence @badlogic