feat(ai): refactor device code login for copilot#4788
Merged
Conversation
1a2cc95 to
b9f146c
Compare
Member
Author
|
We're still auto-opening the browser for the Copilot login, so headless login won't work. Should we instead print the URL? |
Member
Yes. We should not try to open the browser here. |
Member
Author
Member
Author
Ack, will make that change! |
b9f146c to
8b17aca
Compare
Member
Author
|
Done |
e718c0f to
647854e
Compare
647854e to
c554364
Compare
Collaborator
|
Follow-up cleanup after merging:
This comment is AI-generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We're later adding a Codex login option for device code (#3424). In preparation for that, this adds a new device code oauth path and refactors the existing GitHub Copilot login to use it.
Also tested with the standalone pi-ai package login, e.g.