fix(coding-agent): scroll shared tool entries to rendered tool calls#4664
Merged
badlogic merged 1 commit intoMay 18, 2026
Merged
Conversation
Collaborator
|
cheers! |
|
5d4859590a0f9ca41d17a35a0d0023b1326943ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
/shareHTML sidebar navigation for tool result entries.Tool results are listed in the sidebar as session entries, but their visible content is rendered inside the assistant message’s tool-call block. Sidebar clicks previously tried to scroll to a non-existent
entry-<toolResultId>element.This adds stable tool-call DOM ids and maps tool result entries to their rendered tool-call element when scrolling.
Testing
npm run check