Fix(coding-agent) Updated system-prompt.ts to use xml boundaries #4541
Merged
Conversation
Collaborator
|
@herrnel this does not reference the issue it belongs to. the commit does not close the issue via "closes #xyz". the pr description is overly long and could be a paragraph plus an example of what the new fences look like. |
badlogic
reviewed
May 16, 2026
Collaborator
|
@herrnel i left a review, please fix. |
Contributor
Author
|
@badlogic understood, will fix asap |
f22c8d9 to
aa37368
Compare
Contributor
Author
|
@badlogic fixed. |
|
Why not sync commit msg with PR description? Otherwise that info is lost if Pi were to migrate to a different git provider than Github in the future. |
…ext file merging rather than using `##` so that agents are less likely to ingest a prompt with inconsistent boundaries.
aa37368 to
e2fd651
Compare
Contributor
Author
|
@overtongeist good call out. The commit lacked reasoning. |
|
Your PR description is still vastly bigger than the commit msg. Commit msg have a title, and a body, and the body doesn't have any size length limit. |
Collaborator
|
@herrnel cheers! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System prompt's (System.md) and context files (AGENT.md, CLAUDE.md) are merged together using
##headers as a way to create file boundaries. Currently, context file boundaries can become unclear for agents when a user uses##headers or worse#in their context files. A good solution is to use the less commonly used xml tags as file context boundaries instead of##which are more commonly used.Fix:
# Project Contextwith<project_context></project_context## fake/file/path/AGENTS.mdwith<project_instruction path="fake/file/path/AGENTS.md"></project_instruction>Example:
Fixes: #4319