Fixes #1511: Double the size of the Avatar#1595
Merged
eamodio merged 2 commits intogitkraken:mainfrom Nov 4, 2021
Merged
Conversation
eamodio
requested changes
Nov 3, 2021
Member
eamodio
left a comment
There was a problem hiding this comment.
Excellent approach, but we should move your fix here.
Add size *= 2; to before line 77 below
https://github.com/Axosoft/vscode-gitlens/blob/36de8cf5451b609c3596570540f60c645b0dc943/src/avatars.ts#L75-L77
Contributor
Author
|
@eamodio Updated. PTAL |
Member
|
Thank you so much for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #1511
Description
I tried to solve the problem that the avatar of the retina screen is very blurred, but I don't think I did well.
I am not particularly familiar with vscode plugin development. I don't know how to judge whether the current screen is a retinal screen, at the same time, it is not sure whether directly doubling the size of the avatar will cause other problems.
If I bring trouble to you, please forgive me. I really hope someone can help.
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses