Add commands for stash explorer#102
Closed
rebornix wants to merge 17 commits intogitkraken:feature-explorerfrom
Closed
Add commands for stash explorer#102rebornix wants to merge 17 commits intogitkraken:feature-explorerfrom
rebornix wants to merge 17 commits intogitkraken:feature-explorerfrom
Conversation
Gets a properly constructed commit to improve performance of opening the diff
Removes status node for now
Adds refresh commands for explorer views Adds context menu commands to both explorer views
Adds templating support to explorer views
eamodio
reviewed
Jun 27, 2017
| } | ||
|
|
||
| async execute(args: StashDeleteCommandArgs = { confirm: true }) { | ||
| async execute(args: StashDeleteCommandArgs | StashCommitNode = { confirm: true }) { |
Member
There was a problem hiding this comment.
@rebornix Can we use the new run method like here: https://github.com/eamodio/vscode-gitlens/blob/feature-explorer/src/commands/diffWithPrevious.ts#L25
That way the dealing with the node and refreshing it could be specific for that context?
c60eece to
2f8cfb1
Compare
Member
|
@rebornix sorry for the mess I made out of this PR with all the rebasing. I've "merged" this in to the Let me know what you think. |
Member
|
This has been "merged" closing... |
billsedison
added a commit
to noside911/vscode-gitlens
that referenced
this pull request
Jan 4, 2019
Revert "Added documentation for packaging and fixed some issues for prod environment"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is
Right now I reference types from View, which is not good. @eamodio let me know your take on this.