Skip to content

Fix Clublog/eQSL upload dialog empty after LoTW upload#999

Merged
ea4k merged 2 commits into
masterfrom
claude/fix-issue-543-NaUnY
May 7, 2026
Merged

Fix Clublog/eQSL upload dialog empty after LoTW upload#999
ea4k merged 2 commits into
masterfrom
claude/fix-issue-543-NaUnY

Conversation

@ea4k

@ea4k ea4k commented May 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes getGridsToBeSent() in dataproxy_sqlite.cpp which incorrectly filtered QSOs by lotw_qsl_sent for all non-LoTW export modes
  • After uploading to LoTW, QSOs have lotw_qsl_sent='Y', so the old filter excluded them from the Clublog/eQSL grid combo box, leaving it empty and preventing upload
  • Now uses the correct field per service: clublog_qso_upload_status='M' for ClubLog, eqsl_qsl_sent='Q' for eQSL, qrzcom_qso_upload_status='M' for QRZ

Root cause

getGridsToBeSent() had this logic:

if ((_justModified) && (_em == ModeLotW))
    _query_justQueued = "lotw_qsl_sent='Q'";
else
    _query_justQueued = "((lotw_qsl_sent!='1') OR (lotw_qsl_sent IS NULL))";

When called from the Clublog or eQSL upload dialog (_justModified=true, _em=ModeClubLog/ModeEQSL), it fell into the else branch and still filtered by lotw_qsl_sent. After uploading to LoTW those records have lotw_qsl_sent='Y', so the query returned no grids → empty dialog.

The fix mirrors the pattern already used in getQueryJustModifiedString(), switching on ExportMode to pick the right field for each service.

Test plan

  • Add a QSO with CLUBLOG_QSO_UPLOAD_STATUS=M and LOTW_QSL_SENT=Q
  • Upload the QSO to LoTW (sets LOTW_QSL_SENT=Y)
  • Open "Upload queued QSOs to ClubLog" — station callsign and grid locator should now populate correctly and the QSO should appear in the list
  • Repeat for eQSL and QRZ upload dialogs

Fixes #543
Fixes #524

https://claude.ai/code/session_015JVXUp8QpZe8zj1qMpnMJc

After uploading QSOs to LoTW, the grid locator combo box in the
Clublog/eQSL upload dialog was empty because getGridsToBeSent() was
filtering by lotw_qsl_sent for all non-LoTW modes instead of using
the appropriate field for each service (clublog_qso_upload_status,
eqsl_qsl_sent, qrzcom_qso_upload_status).

Fixes #543 #524

https://claude.ai/code/session_015JVXUp8QpZe8zj1qMpnMJc
@ea4k ea4k force-pushed the claude/fix-issue-543-NaUnY branch from 1a51800 to faec5e9 Compare May 7, 2026 15:27
@ea4k ea4k changed the title Support multiple QSO upload modes in grid query logic Fix Clublog/eQSL upload dialog empty after LoTW upload May 7, 2026
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

@ea4k ea4k merged commit 83b86f3 into master May 7, 2026
5 of 10 checks passed
@ea4k ea4k deleted the claude/fix-issue-543-NaUnY branch May 7, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants