Fix Clublog/eQSL upload dialog empty after LoTW upload#999
Merged
Conversation
After uploading QSOs to LoTW, the grid locator combo box in the Clublog/eQSL upload dialog was empty because getGridsToBeSent() was filtering by lotw_qsl_sent for all non-LoTW modes instead of using the appropriate field for each service (clublog_qso_upload_status, eqsl_qsl_sent, qrzcom_qso_upload_status). Fixes #543 #524 https://claude.ai/code/session_015JVXUp8QpZe8zj1qMpnMJc
1a51800 to
faec5e9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
getGridsToBeSent()indataproxy_sqlite.cppwhich incorrectly filtered QSOs bylotw_qsl_sentfor all non-LoTW export modeslotw_qsl_sent='Y', so the old filter excluded them from the Clublog/eQSL grid combo box, leaving it empty and preventing uploadclublog_qso_upload_status='M'for ClubLog,eqsl_qsl_sent='Q'for eQSL,qrzcom_qso_upload_status='M'for QRZRoot cause
getGridsToBeSent()had this logic:When called from the Clublog or eQSL upload dialog (
_justModified=true,_em=ModeClubLog/ModeEQSL), it fell into theelsebranch and still filtered bylotw_qsl_sent. After uploading to LoTW those records havelotw_qsl_sent='Y', so the query returned no grids → empty dialog.The fix mirrors the pattern already used in
getQueryJustModifiedString(), switching onExportModeto pick the right field for each service.Test plan
CLUBLOG_QSO_UPLOAD_STATUS=MandLOTW_QSL_SENT=QLOTW_QSL_SENT=Y)Fixes #543
Fixes #524
https://claude.ai/code/session_015JVXUp8QpZe8zj1qMpnMJc