Fix 3.1.0 upgrade problems, restore and enhance serialization prefs#335
Merged
wolfgangmm merged 7 commits intoeXist-db:developfrom Nov 23, 2021
Merged
Fix 3.1.0 upgrade problems, restore and enhance serialization prefs#335wolfgangmm merged 7 commits intoeXist-db:developfrom
wolfgangmm merged 7 commits intoeXist-db:developfrom
Conversation
Member
Author
|
@wolfgangmm Thanks for your help on today's Community Call! I tried integrating your suggestions—in ced6868. But, as my comment in preferences.js line 40 states, the addition of
This is strange, because the same expression can be found elsewhere in preferences.js. Do you have any suggestions for dynamically registering the version? |
Member
Author
ced6868 to
5f4b11c
Compare
joewiz
added a commit
to joewiz/eXide
that referenced
this pull request
Nov 13, 2021
As suggested by Wolfgang in eXist-db#335 (review)
6a6a577 to
23db910
Compare
wolfgangmm
reviewed
Nov 16, 2021
wolfgangmm
reviewed
Nov 16, 2021
23db910 to
3214347
Compare
This endpoint is called in various scenarios, and they don't all involve downloading xars. When the ?info endpoint is called (e.g., deployment.xql?info=%2Fdb%2Fapps%2Fdoc), eXide 3.1.0 would raise a 400 error, because, since this request has nothing to do with serialization, indent and expand-xincludes parameters are not supplied. The values chosen for the defaults here - indent=no and expand-xincludes=no - simply match that of the pre-eXide 3.1.0 defaults.
17c9dfc to
c2b207a
Compare
wolfgangmm
approved these changes
Nov 23, 2021
Member
Author
|
@wolfgangmm Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues introduced in the eXide 3.1.0 release by #328.
Adds fine-grained serialization preferences:
Closes #333 and #334.