Skip to content

Update Quality Level 1 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogs9 merged 9 commits into from
Mar 23, 2021
Merged

Update Quality Level 1 #62

pablogs9 merged 9 commits into from
Mar 23, 2021

Conversation

@pablogs9
Copy link
Contributor

@pablogs9 pablogs9 commented Mar 9, 2021 •
edited
Loading

Related:

TODO:

  • uncrustify
  • check Synopsis
  • CodeQL

When merged update the version to v1.2.2 and create a release.

@pablogs9 pablogs9 requested review from FranFin and jamoralp March 9, 2021 09:43
@pablogs9 pablogs9 force-pushed the feature/add_quality_level branch from e8f0b5a to 3f34967 Compare March 9, 2021 09:46
@pablogs9
Initial
7992edc 
Signed-off-by: Pablo Garrido
<pablogarrido@eprosima.com>
Signed-off-by: Your Name <you@example.com>
@pablogs9 pablogs9 force-pushed the feature/add_quality_level branch from 3f34967 to 7992edc Compare March 9, 2021 09:48
@richiprosima
Copy link
Contributor

richiprosima commented Mar 9, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Update
ccaaf98 
Signed-off-by: Pablo Garrido
<pablogarrido@eprosima.com>
Signed-off-by: Your Name <you@example.com>
@pablogs9 pablogs9 force-pushed the feature/add_quality_level branch 2 times, most recently from 1671c0e to 4d9120f Compare March 9, 2021 09:57
@richiprosima
Copy link
Contributor

richiprosima commented Mar 9, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 force-pushed the feature/add_quality_level branch 2 times, most recently from 0bcc625 to 80ad0ad Compare March 9, 2021 10:05
@pablogs9 @jamoralp
Create codeql-analysis.yml (#61)
6cde637 
Co-authored-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
Signed-off-by: Your Name <you@example.com>
@pablogs9 pablogs9 force-pushed the feature/add_quality_level branch from 80ad0ad to 6cde637 Compare March 9, 2021 10:05
@richiprosima
Copy link
Contributor

richiprosima commented Mar 9, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Update
1132f09 
Signed-off-by: Your Name <you@example.com>
@pablogs9 pablogs9 force-pushed the feature/add_quality_level branch from 309a5d0 to 1132f09 Compare March 9, 2021 10:20
@richiprosima
Copy link
Contributor

richiprosima commented Mar 9, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Mar 15, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Mar 15, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

FranFin
FranFin suggested changes Mar 18, 2021
View reviewed changes
@pablogs9 @FranFin
Apply suggestions from code review
e898c4d 
Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>
@pablogs9 pablogs9 requested a review from FranFin March 18, 2021 15:15
@richiprosima
Copy link
Contributor

richiprosima commented Mar 18, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 merged commit 768ef96 into develop Mar 23, 2021
@pablogs9 pablogs9 deleted the feature/add_quality_level branch March 23, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamoralp jamoralp Awaiting requested review from jamoralp

1 more reviewer

@FranFin FranFin FranFin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogs9 @richiprosima @FranFin