Skip to content

Release review #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BorjaOuterelo merged 1 commit into from
Oct 31, 2018
Merged

Release review #18

BorjaOuterelo merged 1 commit into from
Oct 31, 2018

Conversation

@julionce
Copy link
Contributor

@julionce julionce commented Oct 29, 2018

This pull request contains minus changes related with packaging installation.
Now CMake configuration file are installed into share folder instead of lib.

@BorjaOuterelo BorjaOuterelo removed their assignment Oct 30, 2018
@lemunozm lemunozm assigned julionce and BorjaOuterelo and unassigned lemunozm and julionce Oct 31, 2018
@BorjaOuterelo BorjaOuterelo merged commit dfe0ff7 into develop Oct 31, 2018
@lemunozm lemunozm deleted the feature/release_review branch November 5, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemunozm lemunozm Awaiting requested review from lemunozm

1 more reviewer

@BorjaOuterelo BorjaOuterelo BorjaOuterelo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BorjaOuterelo BorjaOuterelo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@julionce @BorjaOuterelo @lemunozm