Conversation
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…on methods Signed-off-by: Carlosespicur <carlosespicur@proton.me>
… discovery Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
d394e69 to
4143dcb
Compare
…ceiving a proxy sample Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Merged
10 tasks
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
a2632fc to
b56755a
Compare
Mario-DL
suggested changes
Jun 11, 2025
Contributor
Mario-DL
left a comment
There was a problem hiding this comment.
This PR carries a lot of work. Nice effort with the serialization.
Apart from the comments below, please review the mocks since compilation is failing
Contributor
Author
Compilation fails because the related Fast DDS PR is still opened. I think we can wait until merging it and rerun the CI |
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Mario-DL
reviewed
Jun 11, 2025
…est case Signed-off-by: Carlosespicur <carlosespicur@proton.me>
3a9f391 to
62bfb93
Compare
Mario-DL
reviewed
Jun 12, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
It seems that the fastdds build is taken from an artifact compiled in ihe nightly, I reordered the nightly compilation to be able to retrieve Fast DDS master compilation including the dependent PR |
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Mario-DL
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows storing in the database the deserialized information of the optional QoS sent through the Monitor Service topic, enabling its visualization in Fast DDS Monitor. To achieve this, a structure named
ExtendedMonitorServiceStatusDatahas been added, which contains the deserializedMonitorServiceStatusDatasample, as well as the deserialized optional QoS, in JSON format, extracted from the received proxy samples.Additionally, the History QoS information is now stored in discovery, even though it is optional.
Should be merged after: