Skip to content

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins (backport #974)#976

Merged
Javgilavi merged 1 commit into3.0.xfrom
mergify/bp/3.0.x/pr-974
Feb 12, 2025
Merged

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins (backport #974)#976
Javgilavi merged 1 commit into3.0.xfrom
mergify/bp/3.0.x/pr-974

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Dec 11, 2024

Description

This PR adds documentation for the new properties added in eProsima/Fast-DDS#5450

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.
This is an automatic backport of pull request #974 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Dec 11, 2024
@mergify
Copy link
Copy Markdown
Author

mergify bot commented Dec 11, 2024

Cherry-pick of cc95496 has failed:

On branch mergify/bp/3.0.x/pr-974
Your branch is up to date with 'origin/3.0.x'.

You are currently cherry-picking commit cc95496.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/fastdds/security/access_control_plugin/access_control_plugin.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   code/DDSCodeTester.cpp
	both modified:   code/XMLTester.xml
	both modified:   docs/fastdds/property_policies/security.rst
	both modified:   docs/fastdds/security/auth_plugin/auth_plugin.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Dec 11, 2024
Merged
8 tasks
@MiguelCompany MiguelCompany added this to the v3.0.2 milestone Dec 11, 2024
@Javgilavi Javgilavi self-requested a review February 12, 2025 07:18
@MiguelCompany @Mario-DL
Document new transmit_algorithms_as_legacy on builtin security plug…
df0b7d3 
…ins (#974)

* Refs #19925. Add documentation of new property in PKIDH.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #19925. Add documentation of new property in Permissions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Apply suggestions from code review

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit cc95496)
@Javgilavi Javgilavi force-pushed the mergify/bp/3.0.x/pr-974 branch from 58b4d30 to df0b7d3 Compare February 12, 2025 09:41
@Javgilavi Javgilavi requested review from Javgilavi and removed request for Javgilavi February 12, 2025 09:41
@Javgilavi Javgilavi requested review from Javgilavi and removed request for Javgilavi February 12, 2025 09:42
Javgilavi
Javgilavi approved these changes Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Javgilavi Javgilavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Javgilavi Javgilavi merged commit 397c992 into 3.0.x Feb 12, 2025
5 checks passed
@Javgilavi Javgilavi deleted the mergify/bp/3.0.x/pr-974 branch February 12, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Javgilavi Javgilavi Javgilavi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.0.2 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@Javgilavi @MiguelCompany