Skip to content

[21578] Fix master build to run on Ubuntu 24.04#856

Merged
JesusPoderoso merged 2 commits intomasterfrom
hotfix/21309
Sep 18, 2024
Merged

[21578] Fix master build to run on Ubuntu 24.04#856
JesusPoderoso merged 2 commits intomasterfrom
hotfix/21309

Conversation

@JesusPoderoso
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso commented Jul 9, 2024 •
edited
Loading

Description

On previous PR the swig4.1 dependency was introduced, which is only native available in ubuntu-24.04 github runners.
This PR migrates all master workflows from ubuntu-22.04 to ubuntu-24.04.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • N/A Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v2.14.3 milestone Jul 9, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 9, 2024
EduPonz
EduPonz previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz mentioned this pull request Jul 9, 2024
Merged
9 tasks
@EduPonz EduPonz self-requested a review July 9, 2024 12:55
@EduPonz EduPonz mentioned this pull request Jul 9, 2024
Merged
5 tasks
@EduPonz EduPonz added to-do and removed ci-pending labels Jul 9, 2024
@EduPonz EduPonz dismissed their stale review July 9, 2024 13:48

The merge-base changed after approval.

@EduPonz EduPonz modified the milestones: v2.14.3, v3.0.0 Jul 9, 2024
@elianalf elianalf modified the milestones: v3.0.0, v3.0.1 Jul 24, 2024
@Mario-DL Mario-DL changed the title [21309] Fix master build to run on Ubuntu 24.04 [21578] Fix master build to run on Ubuntu 24.04 Sep 5, 2024
@JesusPoderoso
Refs #21309: Fix master build to run on Ubuntu 24.04
05af737 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for EduPonz and richiprosima September 5, 2024 11:03
@JesusPoderoso JesusPoderoso requested review from richiware and removed request for richiprosima September 11, 2024 10:32
@Mario-DL Mario-DL self-requested a review September 12, 2024 10:26
@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL September 12, 2024 10:48
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL and richiware September 12, 2024 10:49
@Mario-DL
Copy link
Copy Markdown
Contributor

Mario-DL commented Sep 12, 2024

We internally agreed to move it to 3.0.2

@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL September 18, 2024 08:39
@JesusPoderoso
Refs #21309: Downgrarde Swig version to 4.1
0ad1b10 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL September 18, 2024 10:18
Mario-DL
Mario-DL approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso merged commit 30b7f05 into master Sep 18, 2024
@JesusPoderoso JesusPoderoso deleted the hotfix/21309 branch September 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

@EduPonz EduPonz EduPonz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JesusPoderoso JesusPoderoso

Labels

ready-to-merge

Projects

None yet

Milestone

v3.0.2 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

5 participants

@JesusPoderoso @Mario-DL @EduPonz @rsanchez15 @elianalf