Skip to content

[16732] on_unacknowledged_sample_removed documentation#439

Merged
MiguelCompany merged 3 commits intomasterfrom
feature/sample-removed-unacknowdleged
Feb 8, 2023
Merged

[16732] on_unacknowledged_sample_removed documentation#439
MiguelCompany merged 3 commits intomasterfrom
feature/sample-removed-unacknowdleged

Conversation

@JLBuenoLopez
Copy link
Copy Markdown
Contributor

This PR includes documentation of the new DataWriterListener callback on_unacknowledged_sample_removed. It should be merged once the implementation has been done in Fast DDS.

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
…Tester

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Copy Markdown
Contributor Author

CI should fail because the Fast DDS branch does not have the exact same name.
Here a manual CI job is run.

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Copy Markdown
Member

New manual CI here

@JLBuenoLopez
Copy link
Copy Markdown
Contributor Author

Another manual CI

@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Feb 8, 2023
@MiguelCompany MiguelCompany merged commit 57fa004 into master Feb 8, 2023
@MiguelCompany MiguelCompany deleted the feature/sample-removed-unacknowdleged branch February 8, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants