Skip to content

[23325] Add generic interfaces for RPC servers#1088

Merged
MiguelCompany merged 8 commits intomasterfrom
feature/23325
Jun 17, 2025
Merged

[23325] Add generic interfaces for RPC servers#1088
MiguelCompany merged 8 commits intomasterfrom
feature/23325

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jun 16, 2025 •
edited by Carlosespicur
Loading

Description

This PR adds the new classes to the API reference documentation

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@MiguelCompany
Refs #23325. Add RpcRequest.
e6695fc 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23325. Add RpcServer.
dd617a1 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23325. Add RpcServerSchedulingStrategy.
eccce9d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23325. Add API to aliases-api.
ca55ebd 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Jun 16, 2025
@MiguelCompany MiguelCompany mentioned this pull request Jun 16, 2025
Merged
11 tasks
Carlosespicur
Carlosespicur reviewed Jun 16, 2025
View reviewed changes
@MiguelCompany
Refs #23325. Apply review suggestions.
2da4ced 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@Carlosespicur
Copy link
Copy Markdown
Contributor

Carlosespicur commented Jun 16, 2025 •
edited
Loading

Perhaps we should add here a comment explaining that user can implement his own Scheduling strategies, using the new interface. Example's signatures should also be updated to use the new interface names (if types are regenerated).

@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Jun 16, 2025

Perhaps we should add here a comment explaining that user can implement his own Scheduling strategies, using the new interface. Example's signatures should also be updated to use the new interface names (if types are regenerated).

This will be done in a follow-up PR

@MiguelCompany
Refs #23325. Regenerate code.
3d31dd6 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from Carlosespicur and removed request for Carlosespicur June 16, 2025 10:14
@MiguelCompany
Refs #23325. Update server code.
2688a4d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from Carlosespicur and removed request for Carlosespicur June 16, 2025 10:36
@MiguelCompany
Refs #23325. Fix path in literal include.
32cb975 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from Carlosespicur and removed request for Carlosespicur June 16, 2025 10:58
@rsanchez15 rsanchez15 mentioned this pull request Jun 16, 2025
Merged
7 tasks
@MiguelCompany MiguelCompany mentioned this pull request Jun 17, 2025
Merged
7 tasks
@MiguelCompany MiguelCompany merged commit ccc09a8 into master Jun 17, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/23325 branch June 17, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Carlosespicur Carlosespicur Carlosespicur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Carlosespicur