Skip to content

[24182] Extend DomainParticipant API to include return codes#6314

Merged
rsanchez15 merged 5 commits intomasterfrom
feature/create-api-extension
Feb 25, 2026
Merged

[24182] Extend DomainParticipant API to include return codes#6314
rsanchez15 merged 5 commits intomasterfrom
feature/create-api-extension

Conversation

@emiliocuestaf
Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf commented Feb 19, 2026

Description

This PR extends the public API of DomainParticipant.h to include "create_X(..., RetCode_t &ret, ...)" functions, which have the return code as an output argument.

This PR depends on #6308 and must be merged after that one. That PR already extended the API for the RPC-related entities, this is just a continuation of that work. Once it has been merged, please do a git rebase --onto to correctly squash all the commits coming from that PR as done in master.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@emiliocuestaf emiliocuestaf added this to the v3.5.0 milestone Feb 19, 2026
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 19, 2026
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 19, 2026 07:00
@emiliocuestaf emiliocuestaf changed the base branch from master to fast/rpc-refactor February 19, 2026 07:40
@emiliocuestaf emiliocuestaf changed the title Feature/create api extension [24182] DomainParticipant API extension to include return codes Feb 19, 2026
@emiliocuestaf emiliocuestaf changed the title [24182] DomainParticipant API extension to include return codes [24182] Extend DomainParticipant API to include return codes Feb 19, 2026
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small NITs

cferreiragonz
cferreiragonz previously approved these changes Feb 24, 2026
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. We must wait for the related PR to be merged before and rebase afterwards

Base automatically changed from fast/rpc-refactor to master February 24, 2026 11:46
@rsanchez15 rsanchez15 dismissed cferreiragonz’s stale review February 24, 2026 11:46

The base branch was changed.

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf force-pushed the feature/create-api-extension branch from 2d0a29b to 83ee9de Compare February 24, 2026 11:52
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz removed the request for review from richiprosima February 24, 2026 12:00
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 25, 2026

🧪 CI Insights

Here's what we observed from your CI run for 83ee9de.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@emiliocuestaf emiliocuestaf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 25, 2026
@rsanchez15 rsanchez15 merged commit a8c4f20 into master Feb 25, 2026
32 of 40 checks passed
@rsanchez15 rsanchez15 deleted the feature/create-api-extension branch February 25, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants