Skip to content

[24066] Enhance filtering logic for virtual and external endpoints#6290

Merged
MiguelCompany merged 12 commits intomasterfrom
hotfix-ds-superclient
Feb 6, 2026
Merged

[24066] Enhance filtering logic for virtual and external endpoints#6290
MiguelCompany merged 12 commits intomasterfrom
hotfix-ds-superclient

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jan 30, 2026 •
edited by cferreiragonz
Loading

Description

This PR ensures that Servers only communicate with their direct clients.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Enhance filtering logic for virtual and external endpoints
f274be8 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 30, 2026
@MiguelCompany MiguelCompany marked this pull request as draft January 30, 2026 07:48
@raulojeda22
Restore proper filtering for external endpoint discovery matching
a2148ec 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
Uncrustify
75a02b2 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima January 30, 2026 08:34
cferreiragonz
cferreiragonz requested changes Jan 30, 2026
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 30, 2026 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for ea5b4ba.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@raulojeda22
Add DS test checking external-to-external relay
a24b28a 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
Add additional logic to reader_gives_info and uncrustify
585bf29 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
Remove unnecessary comment
8afecae 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
Remove leaseDuration config to trigger test error in previous code
f02cb1a 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22 raulojeda22 marked this pull request as ready for review February 3, 2026 10:54
@raulojeda22 raulojeda22 requested review from richiprosima and removed request for richiprosima February 3, 2026 10:56
@raulojeda22 raulojeda22 added this to the v3.5.0 milestone Feb 3, 2026
@cferreiragonz cferreiragonz changed the title Enhance filtering logic for virtual and external endpoints [24066] Enhance filtering logic for virtual and external endpoints Feb 4, 2026
@raulojeda22
Add additional logic to writer_gives_info
7b42910 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
Remove unnecessary extra logic on match_writer_reader
d90d1f9 
Signed-off-by: Raül <raulojeda@eprosima.com>
cferreiragonz
cferreiragonz requested changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs and what we talked internally.

cferreiragonz
cferreiragonz requested changes Feb 4, 2026
View reviewed changes
@raulojeda22
Apply revision
8bfd5d3 
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
Add explicit _not_virtual to _is_local variable name
5587f55 
Signed-off-by: Raül <raulojeda@eprosima.com>
cferreiragonz
cferreiragonz previously approved these changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima February 4, 2026 14:04
@raulojeda22
Fix DS test failing in windows CI
ea5b4ba 
Signed-off-by: Raül <raulojeda@eprosima.com>
cferreiragonz
cferreiragonz approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 6, 2026
@MiguelCompany MiguelCompany merged commit 3d2479e into master Feb 6, 2026
23 of 26 checks passed
@MiguelCompany MiguelCompany deleted the hotfix-ds-superclient branch February 6, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulojeda22 raulojeda22 raulojeda22 left review comments

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.5.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@MiguelCompany @raulojeda22 @cferreiragonz