Skip to content

[24035] Fix compilation on PDPTests#6226

Merged
MiguelCompany merged 2 commits intomasterfrom
bugfix/compile-openssl
Jan 7, 2026
Merged

[24035] Fix compilation on PDPTests#6226
MiguelCompany merged 2 commits intomasterfrom
bugfix/compile-openssl

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Dec 31, 2025

Description

Compilation of PDPTests fails if NO_TLS Cmake option is set to ON.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Fix compilation on PDPTests [24035] Fix compilation on PDPTests Dec 31, 2025
raulojeda22
raulojeda22 previously approved these changes Dec 31, 2025
Copy link
Copy Markdown
Contributor

@raulojeda22 raulojeda22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it compiles without errors

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add one step to the alternative builds CI with -DNO_TLS=ON ?

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the bugfix/compile-openssl branch from c1ec3e5 to 780e29b Compare January 7, 2026 11:40
@richiware richiware added this to the v3.5.0 milestone Jan 7, 2026
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jan 7, 2026
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green build

@MiguelCompany
Copy link
Copy Markdown
Member

All builds green, going in.

@MiguelCompany MiguelCompany merged commit 7834a88 into master Jan 7, 2026
22 of 28 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/compile-openssl branch January 7, 2026 15:20
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 7, 2026

🧪 CI Insights

Here's what we observed from your CI run for 780e29b.

🟢 All jobs passed!

But CI Insights is watching 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants