[23847] Protect DataReaderInstance alive_writers attribute (backport #6123)#6160
Merged
MiguelCompany merged 2 commits into2.14.xfrom Nov 11, 2025
Merged
[23847] Protect DataReaderInstance alive_writers attribute (backport #6123)#6160MiguelCompany merged 2 commits into2.14.xfrom
MiguelCompany merged 2 commits into2.14.xfrom
Conversation
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 19d6a2b) # Conflicts: # src/cpp/fastdds/subscriber/history/DataReaderHistory.cpp
Contributor
Author
|
Cherry-pick of 19d6a2b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
approved these changes
Nov 6, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to solve the data race produced in intraprocess scenario, when a writer sends a message from a thread (which updates its associated instance state in the reader receiving the message: DataReaderImpl::on_new_cache_change_added → DataReaderHistory::update_instance_nts → … → DataReaderInstance::writer_set), while from another thread the instances state of the same reader is also updated without protection (e.g., when destroying a matched writer: DataReaderImpl::update_subscription_matched_status → … → DataReaderInstance::writer_unregister). In the first thread the reader mutex is taken before calling update_instance_nts, the problem is that in the second thread that mutex is never taken.
@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6123 done by [Mergify](https://mergify.com).