[23822] Protect PDPStatelessWriter attributes (backport #6100)#6152
Merged
juanlofer-eprosima merged 1 commit into3.3.xfrom Dec 3, 2025
Merged
[23822] Protect PDPStatelessWriter attributes (backport #6100)#6152juanlofer-eprosima merged 1 commit into3.3.xfrom
juanlofer-eprosima merged 1 commit into3.3.xfrom
Conversation
12 tasks
cferreiragonz
approved these changes
Nov 25, 2025
Contributor
Author
Contributor
|
@Mergifyio rebase |
* Refs #23822. Protect PDPStatelessWriter attributes Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23822. Atomize matched_ attribute Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23822. Protect reader_data_filter_ attribute Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 6ca678b)
Contributor
Author
✅ Branch has been successfully rebased |
50c943a to
a2e9cce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to solve the data race produced when a thread clears the attributes of PDPStatelssWriter at mark_all_readers_interested (called in announceParticipantState from events thread, for example), while the values are read from another thread (send_to_fixed_locators called, for example, from the asynchronous send thread → LocatorSelectorSender::send → StatelessWriter::send_nts → PDPStatelessWriter::send_to_fixed_locators).
@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6100 done by [Mergify](https://mergify.com).