Skip to content

Fix wrong namespace when indicating CDR version#6139

Merged
MiguelCompany merged 1 commit into2.14.xfrom
hotfix/ill-cdrversion-namespace
Nov 4, 2025
Merged

Fix wrong namespace when indicating CDR version#6139
MiguelCompany merged 1 commit into2.14.xfrom
hotfix/ill-cdrversion-namespace

Conversation

@emiliocuestaf
Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf commented Nov 3, 2025

Description

This PR fixes a wrong namespace that was backported. It caused Fast DDS 2.14.x compilation to fail when using Fast CDR 1.1.x.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [ N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf added this to the v2.14.6 milestone Nov 3, 2025
@emiliocuestaf emiliocuestaf added the ci-pending PR which CI is running label Nov 3, 2025
@emiliocuestaf
Copy link
Copy Markdown
Contributor Author

Build against Fast CDR 1.1.x checked here: https://github.com/eProsima/eProsima-CI/actions/runs/19033986319

@emiliocuestaf emiliocuestaf added the no-test Skip CI tests if PR marked with this label label Nov 3, 2025
@emiliocuestaf emiliocuestaf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 4, 2025
@MiguelCompany MiguelCompany merged commit 51862a4 into 2.14.x Nov 4, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/ill-cdrversion-namespace branch November 4, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants