Skip to content

Remove manually change of "/Zi" MSVC option#6133

Merged
richiware merged 1 commit intomasterfrom
feature/msvc-debug-format
Oct 30, 2025
Merged

Remove manually change of "/Zi" MSVC option#6133
richiware merged 1 commit intomasterfrom
feature/msvc-debug-format

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Oct 30, 2025

Description

CMake 3.25 introduces CMAKE_MSVC_DEBUG_INFORMATION_FORMAT to change "/Zi" MSVC option. For this reason this PR remove the manually mechanism to change it. Now a user can this CMAKE options to have the same behaviour:

-DCMAKE_POLICY_DEFAULT_CMP0141=NEW  -DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT="$<$<CONFIG:Debug>:Embedded>"

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

@richiware richiware added this to the v3.5.0 milestone Oct 30, 2025
@github-actions github-actions Bot added the ci-pending PR which CI is running label Oct 30, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Oct 30, 2025
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany October 30, 2025 09:55
@richiware richiware force-pushed the feature/msvc-debug-format branch from 319dfd4 to 452ab7b Compare October 30, 2025 09:56
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany October 30, 2025 09:58
@richiware richiware modified the milestones: v3.5.0, v3.4.1 Oct 30, 2025
Signed-off-by: Ricardo González <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/msvc-debug-format branch from 452ab7b to 2389f4d Compare October 30, 2025 13:03
@MiguelCompany MiguelCompany self-requested a review October 30, 2025 13:16
@richiware richiware merged commit 407cf95 into master Oct 30, 2025
25 checks passed
@richiware richiware deleted the feature/msvc-debug-format branch October 30, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants