[23654] Change non_blocking_send threshold to sendBufferSize (backport #6073)#6079
Merged
juanlofer-eprosima merged 1 commit into2.14.xfrom Oct 8, 2025
Merged
Conversation
Contributor
Author
|
Cherry-pick of 81a5b12 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 81a5b12) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp
2e91a76 to
c97666f
Compare
Contributor
Author
juanlofer-eprosima
approved these changes
Oct 8, 2025
Contributor
juanlofer-eprosima
left a comment
There was a problem hiding this comment.
LGTM, failed tests are unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the non blocking size feature assumes that the size of TCP sockets allocated by the OS is twice the value requested (sendBufferSize). However, it has been observed that the actual reserved value may fall below that value, hence blocking when the buffer gets full and ruining the purpose of this feature.
@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/a Any new/modified methods have been properly documented using Doxygen.
N/a Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/a New feature has been added to the
versions.mdfile (if applicable).N/a New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6073 done by [Mergify](https://mergify.com).