Skip to content

[23647] Remove dynamic network tests#6063

Merged
MiguelCompany merged 8 commits intomasterfrom
feature/23647-remove-bbox
Sep 30, 2025
Merged

[23647] Remove dynamic network tests#6063
MiguelCompany merged 8 commits intomasterfrom
feature/23647-remove-bbox

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Sep 30, 2025

Description

This removes all tests related to IP mobility, since it is a Fast DDS Pro only feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Sep 30, 2025
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label fast dds pro labels Sep 30, 2025
@github-actions github-actions Bot added the ci-pending PR which CI is running label Sep 30, 2025
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are deleting every test that should not be run in Fast DDS basic I guess we should also delete Communication tests of dynamic network... (test/dds/communication/dyn_network/dynamic_interfaces.compose.yml)

Comment thread test/blackbox/common/DDSBlackboxTestsDiscovery.cpp Outdated
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title [23647] Remove dynamic network blackbox tests [23647] Remove dynamic network tests Sep 30, 2025
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Comment thread test/dds/communication/dyn_network/CMakeLists.txt
Comment thread CMakeLists.txt Outdated
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
cferreiragonz
cferreiragonz previously approved these changes Sep 30, 2025
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit 0abb3ac into master Sep 30, 2025
18 checks passed
@MiguelCompany MiguelCompany deleted the feature/23647-remove-bbox branch September 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running fast dds pro no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants