Skip to content

[23647] Fix build of TypeLookupService_main.cpp#6061

Merged
MiguelCompany merged 1 commit intomasterfrom
hotfix/23647
Sep 30, 2025
Merged

[23647] Fix build of TypeLookupService_main.cpp#6061
MiguelCompany merged 1 commit intomasterfrom
hotfix/23647

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Sep 29, 2025

Description

For reasons I don't yet understand, we need these changes when building this file in Fast DDS Pro, but we don't need them in basic.

They are nevertheless good, since it is always adequate to initialize all members in a structure.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Sep 29, 2025
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label fast dds pro labels Sep 29, 2025
@github-actions github-actions Bot added the ci-pending PR which CI is running label Sep 29, 2025
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record. The compilation issue only appears when building with C++ 11, what seems to indicate that Fast DDS is not correctly enforcing C++ 11 rules.

@MiguelCompany MiguelCompany merged commit 10d29c0 into master Sep 30, 2025
18 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/23647 branch September 30, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running fast dds pro no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants