Skip to content

[23709] Isolate types with const/typedefs inside a struct#6050

Merged
MiguelCompany merged 2 commits intomasterfrom
feature/isolate_inner_const_typedefs
Sep 22, 2025
Merged

[23709] Isolate types with const/typedefs inside a struct#6050
MiguelCompany merged 2 commits intomasterfrom
feature/isolate_inner_const_typedefs

Conversation

@jepemi
Copy link
Copy Markdown
Contributor

@jepemi jepemi commented Sep 18, 2025

Description

This PR updates dds-types-test submodule which now isolates types with const/typedefs inside a struct.

Depends on

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 18, 2025
@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Sep 18, 2025
MiguelCompany
MiguelCompany previously approved these changes Sep 18, 2025
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 0278d17 into master Sep 22, 2025
29 of 31 checks passed
@MiguelCompany MiguelCompany deleted the feature/isolate_inner_const_typedefs branch September 22, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants