Skip to content

[23618] Use binary search in 'find_change_nts' (backport #5997)#6027

Merged
MiguelCompany merged 1 commit into3.2.xfrom
mergify/bp/3.2.x/pr-5997
Oct 12, 2025
Merged

[23618] Use binary search in 'find_change_nts' (backport #5997)#6027
MiguelCompany merged 1 commit into3.2.xfrom
mergify/bp/3.2.x/pr-5997

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Sep 11, 2025

Description

This PR modifies the method find_change_nts to use a binary search instead of a forward search.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5997 done by [Mergify](https://mergify.com).

@cferreiragonz cferreiragonz added this to the v3.2.3 milestone Sep 11, 2025
@MiguelCompany
Copy link
Copy Markdown
Member

@Mergifyio rebase

* Refs #23618: Use binary search in 'find_change_nts'

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23618: Take into account changes with same sequence number

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 434af1b)
@MiguelCompany MiguelCompany force-pushed the mergify/bp/3.2.x/pr-5997 branch from 1e7ab38 to 84e1b8c Compare October 10, 2025 08:53
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Oct 10, 2025

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany self-requested a review October 10, 2025 08:54
@github-actions github-actions Bot added the ci-pending PR which CI is running label Oct 10, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Oct 10, 2025

🧪 CI Insights

Here's what we observed from your CI run for 84e1b8c.

❌ Job Failures

Pipeline Job Health on 3.2.x Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View

@MiguelCompany MiguelCompany merged commit 58d8062 into 3.2.x Oct 12, 2025
27 of 28 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.2.x/pr-5997 branch October 12, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants