Skip to content

[23680] Update generated code script#6019

Merged
MiguelCompany merged 2 commits intomasterfrom
hotfix/fix-broken-type-gen-script
Sep 11, 2025
Merged

[23680] Update generated code script#6019
MiguelCompany merged 2 commits intomasterfrom
hotfix/fix-broken-type-gen-script

Conversation

@emiliocuestaf
Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf commented Sep 9, 2025

Description

The script utils/scripts/update_generated_code_from_idl.sh attempted to generate code from improperly formatted IDL files that are used in certain unit tests for the IDL parser. This PR just adds those file to the script's ignored IDL list.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [N/A] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…ion script

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf added this to the v3.4.0 milestone Sep 9, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 9, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for a409768.

🟢 All jobs passed!

But CI Insights is watching 👀

@MiguelCompany MiguelCompany added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Sep 11, 2025
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com>
@MiguelCompany
Copy link
Copy Markdown
Member

Fast DDS Gen CI with this branch here

@MiguelCompany MiguelCompany merged commit f539ff3 into master Sep 11, 2025
5 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/fix-broken-type-gen-script branch September 11, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci Automatically pass CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants