Skip to content

[23610] Fix duplicated transport when using specific XML with CLI (backport #5988)#6009

Merged
MiguelCompany merged 1 commit into3.3.xfrom
mergify/bp/3.3.x/pr-5988
Oct 7, 2025
Merged

[23610] Fix duplicated transport when using specific XML with CLI (backport #5988)#6009
MiguelCompany merged 1 commit into3.3.xfrom
mergify/bp/3.3.x/pr-5988

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 3, 2025

Description

When an XML file with an user transport and a custom metatrafficUnicastLocatorList is passed to the Fast DDS CLI through the -x command, two TCP transports will be added to user_transports in the end. This PR fixes this behavior by skipping the transport creation if there is already an existing transport created.

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5988 done by [Mergify](https://mergify.com).

* Refs #23610: Test with XML file

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23610: Fix bug when passing XML

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit bfa10bc)
@MiguelCompany MiguelCompany added this to the v3.3.1 milestone Sep 3, 2025
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima October 7, 2025 05:35
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 7, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Oct 7, 2025

🧪 CI Insights

Here's what we observed from your CI run for 8d721e9.

❌ Job Failures

Pipeline Job Health on 3.3.x Retries 🔍 CI Insights 📄 Logs
Fast DDS Ubuntu CI ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@MiguelCompany MiguelCompany merged commit 36e17ef into 3.3.x Oct 7, 2025
24 of 28 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.3.x/pr-5988 branch October 7, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants