Skip to content

[23658] Infrastructure modifications for modularity#6005

Merged
MiguelCompany merged 3 commits intomasterfrom
feature/basic
Sep 4, 2025
Merged

[23658] Infrastructure modifications for modularity#6005
MiguelCompany merged 3 commits intomasterfrom
feature/basic

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Sep 3, 2025

Description

This PR brings infrastructure modifications to achieve modularity and allow use fastdds in future internal projects.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@github-actions github-actions Bot added the ci-pending PR which CI is running label Sep 3, 2025
@richiware richiware changed the title Infrastructure modifications for modularity [23658] Infrastructure modifications for modularity Sep 3, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 3, 2025

🧪 CI Insights

Here's what we observed from your CI run for 82501c5.

❌ Failed Jobs

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / reusable-mac-ci (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, blackbox), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Sep 4, 2025
@richiware richiware mentioned this pull request Sep 4, 2025
13 tasks
Comment thread cmake/common/eprosima_libraries.cmake Outdated
Comment thread cmake/common/eprosima_libraries.cmake
Comment thread cmake/common/eprosima_libraries.cmake Outdated
Comment thread cmake/common/eprosima_libraries.cmake
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
MiguelCompany previously approved these changes Sep 4, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Sep 4, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima September 4, 2025 09:18
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany MiguelCompany merged commit ea9644e into master Sep 4, 2025
5 checks passed
@MiguelCompany MiguelCompany deleted the feature/basic branch September 4, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants