Skip to content

[23435] Add support for ethernet locator kind#5999

Merged
MiguelCompany merged 21 commits intomasterfrom
feature/23435
Sep 10, 2025
Merged

[23435] Add support for ethernet locator kind#5999
MiguelCompany merged 21 commits intomasterfrom
feature/23435

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Sep 3, 2025

Description

This PR adds support for the locator kind defined in section A.3 of DDS-TSN.

It also prepares the XML parser to be easily extended to create an Ethernet transport in Fast DDS Pro.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Sep 3, 2025
@MiguelCompany MiguelCompany force-pushed the feature/23435 branch 2 times, most recently from b18bdb9 to 68f830f Compare September 3, 2025 10:47
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima September 3, 2025 10:50
@github-actions github-actions Bot added the ci-pending PR which CI is running label Sep 3, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima September 3, 2025 13:05
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 3, 2025

🧪 CI Insights

Here's what we observed from your CI run for 20ba5f8.

🟢 All jobs passed!

But CI Insights is watching 👀

@MiguelCompany MiguelCompany force-pushed the feature/23435 branch 3 times, most recently from 8ce8931 to 023df2f Compare September 4, 2025 12:37
@MiguelCompany MiguelCompany force-pushed the feature/23435 branch 2 times, most recently from 8403385 to 4158e23 Compare September 5, 2025 08:24
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
…ser` static method.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested a review from jepemi September 8, 2025 09:50
jepemi

This comment was marked as resolved.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested a review from jepemi September 9, 2025 13:44
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Sep 9, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima September 9, 2025 14:49
@MiguelCompany MiguelCompany removed the no-test Skip CI tests if PR marked with this label label Sep 9, 2025
@MiguelCompany MiguelCompany requested review from jepemi and removed request for jepemi September 9, 2025 15:00
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from jepemi and removed request for jepemi September 10, 2025 05:57
Comment thread test/unittest/utils/LocatorTests.cpp Outdated
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Copy link
Copy Markdown
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit f9cb0ab into master Sep 10, 2025
35 of 37 checks passed
@MiguelCompany MiguelCompany deleted the feature/23435 branch September 10, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running fast dds pro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants