Skip to content

[23558] Change eprosima::fastdds::rtps::octet to be uint8_t according to C++11 standard#5960

Merged
MiguelCompany merged 2 commits intomasterfrom
bugfix/23403
Aug 1, 2025
Merged

[23558] Change eprosima::fastdds::rtps::octet to be uint8_t according to C++11 standard#5960
MiguelCompany merged 2 commits intomasterfrom
bugfix/23403

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Jul 29, 2025

Description

Change eprosima::fastdds::rtps::octet to be uint8_t according to C++11 standard

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware added this to the v3.4.0 milestone Jul 29, 2025
@richiware richiware changed the title Change eprosima::fastdds::rtps::octet to be uint8_t according to C++11 standard [23558] Change eprosima::fastdds::rtps::octet to be uint8_t according to C++11 standard Jul 29, 2025
@MiguelCompany MiguelCompany self-requested a review July 30, 2025 06:31
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 30, 2025
MiguelCompany
MiguelCompany previously approved these changes Jul 30, 2025
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit aba95a5 into master Aug 1, 2025
36 of 38 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23403 branch August 1, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants